jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io
URL: https://github.com/apache/beam/pull/11151#discussion_r409072416
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -469,6 +470,7 @@ class BeamModulePlugin implements Plugin<Project> {
google_cloud_datastore_v1_proto_client :
"com.google.cloud.datastore:datastore-v1-proto-client:1.6.3",
google_cloud_spanner :
"com.google.cloud:google-cloud-spanner:$google_cloud_spanner_version",
google_http_client :
"com.google.http-client:google-http-client:$google_http_clients_version",
+ google_http_client_gson :
"com.google.http-client:google-http-client-gson:$google_http_clients_version",
Review comment:
good question.
I used Gson to be consistent w/ how we do things in the healthcare example
docs and a CDAP plugin that was developed for the same purpose.
It does not seem strictly necessary.
I will prepare a commit to remove gson dep and migrate to jackson.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
