udim commented on a change in pull request #11428: [BEAM-9764] multi threading
& check urls instead of pulling
URL: https://github.com/apache/beam/pull/11428#discussion_r410387421
##########
File path: sdks/java/container/license_scripts/license_script.sh
##########
@@ -25,15 +25,23 @@ pip install PyYAML==5.3
pip install tenacity==5.0.4
# pull licenses, notices and source code
-python sdks/java/container/license_scripts/pull_licenses_java.py
+if [ "$1" = 'true' ]; then
+ python sdks/java/container/license_scripts/pull_licenses_java.py
--pull_licenses
+else
+ python sdks/java/container/license_scripts/pull_licenses_java.py
+fi
pip uninstall -y beautifulsoup4
pip uninstall -y future
pip uninstall -y PyYAML
pip uninstall -y tenacity
mkdir sdks/java/container/third_party_licenses
-gzip -r java_third_party_licenses/*
-cp -r java_third_party_licenses/*.jar sdks/java/container/third_party_licenses/
-cp -r java_third_party_licenses/*.csv.gz
sdks/java/container/third_party_licenses/
+if [ "$1" = 'true' ]; then
+ cp -r java_third_party_licenses/*.jar
sdks/java/container/third_party_licenses/
+ cp -r java_third_party_licenses/*.csv
sdks/java/container/third_party_licenses/
+else
+ # create an empty file to aviod no file/dir existing error
Review comment:
```suggestion
# create an empty file to avoid no file/dir existing error
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
