udim commented on a change in pull request #11428: [BEAM-9764] multi threading & check urls instead of pulling URL: https://github.com/apache/beam/pull/11428#discussion_r410390164
########## File path: sdks/java/container/license_scripts/license_script.sh ########## @@ -25,15 +25,23 @@ pip install PyYAML==5.3 pip install tenacity==5.0.4 Review comment: BTW, I wanted to mention that doing a pip install/uninstall like this messes with the user's environment. The standard way to run this would be via tox (see sdks/python/tox.ini), which will take care of creating a virtualenv to run this under (and you can specify a certain python version if you wish). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
