robertwb commented on a change in pull request #11449: Updates and
clarifications on type safety.
URL: https://github.com/apache/beam/pull/11449#discussion_r410499350
##########
File path: sdks/python/apache_beam/examples/snippets/snippets_test_py3.py
##########
@@ -44,7 +44,7 @@ def test_bad_types_annotations(self):
# pylint: disable=expression-not-assigned
# pylint: disable=unused-variable
class FilterEvensDoFn(beam.DoFn):
- def process(self, element, *unused_args, **unused_kwargs):
Review comment:
Well, mypy and PyCharm are certainly in error here. Possibly it's because we
call DoFns with *args and **kwargs in places, but we construct those to match
the actual signature. Please file a JIRA about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
