udim commented on a change in pull request #11449: Updates and clarifications
on type safety.
URL: https://github.com/apache/beam/pull/11449#discussion_r410504389
##########
File path: sdks/python/apache_beam/examples/snippets/snippets_test_py3.py
##########
@@ -44,7 +44,7 @@ def test_bad_types_annotations(self):
# pylint: disable=expression-not-assigned
# pylint: disable=unused-variable
class FilterEvensDoFn(beam.DoFn):
- def process(self, element, *unused_args, **unused_kwargs):
Review comment:
I believe it's because the base class has *args and **kwargs in the
prototype:
https://github.com/apache/beam/blob/1de50c348706ed25af2bab9c9477d7d4f36ef8bf/sdks/python/apache_beam/transforms/core.py#L621
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
