lukecwik commented on a change in pull request #11454:
URL: https://github.com/apache/beam/pull/11454#discussion_r411509430
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/ByteKeyRangeTracker.java
##########
@@ -64,31 +64,38 @@ public ByteKeyRange currentRestriction() {
@Override
public SplitResult<ByteKeyRange> trySplit(double fractionOfRemainder) {
- // TODO(BEAM-8871): Add support for splitting off a fixed amount of work
for this restriction
- // instead of only supporting checkpointing.
-
- // If we haven't done any work, we should return the original range we
were processing
- // as the checkpoint.
- if (lastAttemptedKey == null) {
- ByteKeyRange rval = range;
- // We update our current range to an interval that contains no elements.
- range = NO_KEYS;
- return SplitResult.of(range, rval);
+ // No split on an empty range.
+ if (NO_KEYS.equals(range)) {
+ return null;
Review comment:
Since restriction trackers return `RestrictionT`, we could only do this
if we updated the `trySplit` method to return `SplitResult<RestrictionT>` where
`SplitResult` would be something like `Optional`.
That could be useful if we wanted to plumb the failure reason for the split
back to the runner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
