lukecwik commented on a change in pull request #11454:
URL: https://github.com/apache/beam/pull/11454#discussion_r414081632
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/ByteKeyRangeTracker.java
##########
@@ -64,31 +64,56 @@ public ByteKeyRange currentRestriction() {
@Override
public SplitResult<ByteKeyRange> trySplit(double fractionOfRemainder) {
- // TODO(BEAM-8871): Add support for splitting off a fixed amount of work
for this restriction
- // instead of only supporting checkpointing.
+ // No split on an empty range.
+ if (NO_KEYS.equals(range)) {
Review comment:
A user can still create a restriction where startkey == endkey, have no
tryClaim calls and be checkpointed which is why we need to support both cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
