robertwb commented on a change in pull request #11524:
URL: https://github.com/apache/beam/pull/11524#discussion_r416000017
##########
File path: sdks/go/test/run_integration_tests.sh
##########
@@ -102,9 +102,8 @@ case $key in
esac
done
-if [[ "$RUNNER" != "universal" ]]; then
- PUSH_CONTAINER_TO_GCR='yes'
-else
+PUSH_CONTAINER_TO_GCR='yes'
Review comment:
I'd guess that is because in Go one wants to use the declare-and-define
syntax, which wouldn't work inside the if clause. The convention is opposite in
Java/Python (where more value is placed on immutability). As for bash, well, I
doubt there's any consistency around there... This is fine if you prefer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
