lostluck commented on a change in pull request #11524:
URL: https://github.com/apache/beam/pull/11524#discussion_r416922273
##########
File path: sdks/go/test/run_integration_tests.sh
##########
@@ -102,9 +102,8 @@ case $key in
esac
done
-if [[ "$RUNNER" != "universal" ]]; then
- PUSH_CONTAINER_TO_GCR='yes'
-else
+PUSH_CONTAINER_TO_GCR='yes'
Review comment:
A fair observation. I ended up with reversing the if clause anyway since
the positive check is clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
