tvalentyn commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r418160747



##########
File path: .test-infra/jenkins/CommonJobProperties.groovy
##########
@@ -163,6 +163,10 @@ class CommonJobProperties {
     // For [BEAM-4847], hardcode Xms and Xmx to reasonable values (2g/4g).
     context.switches("-Dorg.gradle.jvmargs=-Xms2g")
     context.switches("-Dorg.gradle.jvmargs=-Xmx4g")
+
+    // Add docker-pull-licenses option to all Jenkins test to add licenses to 
when build docker images.

Review comment:
       This is my other comment: I suggested on mailing list that we can also 
pull licences whenever we run build containers on the release branch. If 
community does not like that option for some reason, then we should also update 
the release guide in this PR to make sure release manager is aware that they 
need to pass a non-default option, and check that licenses were added 
successfully.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to