tvalentyn commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r418171888
##########
File path: .test-infra/jenkins/CommonJobProperties.groovy
##########
@@ -163,6 +163,10 @@ class CommonJobProperties {
// For [BEAM-4847], hardcode Xms and Xmx to reasonable values (2g/4g).
context.switches("-Dorg.gradle.jvmargs=-Xms2g")
context.switches("-Dorg.gradle.jvmargs=-Xmx4g")
+
+ // Add docker-pull-licenses option to all Jenkins test to add licenses to
when build docker images.
Review comment:
I saw on the mailing list that you have updated release guide to include
the config flags to build images, and will be updating them. You can do those
changes in a follow-up pr.
You can conisider looking at the value of
https://github.com/apache/beam/blob/74a6565c8b64d9fadf256370df47a4c5dadafb55/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L296
to determine whether the task is running for release branch, instead of
asking release manager to pass a config flag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
