[GitHub] [beam] damondouglas commented on a change in pull request #11564: [Beam-9679] Add Core Transforms section / Map lesson to the Go SDK katas

Sun, 03 May 2020 11:40:22 -0700 


damondouglas commented on a change in pull request #11564:
URL: https://github.com/apache/beam/pull/11564#discussion_r419142387



##########
File path: learning/katas/go/Core Transforms/Map/ParDo 
OneToMany/pkg/task/task.go
##########
@@ -21,10 +21,10 @@ import (
 )
 
 func ApplyTransform(s beam.Scope, input beam.PCollection) beam.PCollection {
-       return beam.ParDo(s, processFn, input)
+       return beam.ParDo(s, tokenizeFn, input)
 }
 
-func processFn(input string, emit func(out string)) {
+func tokenizeFn(input string, emit func(out string)) {

Review comment:
       Similar to the previous placeholder issue.  This is what appears when I 
tested the course in both IntelliJ and GoLand:
   
   <img width="717" alt="Screen Shot 2020-05-03 at 11 18 41 AM" 
src="https://user-images.githubusercontent.com/762456/80922546-bacb7a80-8d32-11ea-9486-524d57333235.png";>
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to