henryken commented on a change in pull request #11564:
URL: https://github.com/apache/beam/pull/11564#discussion_r419240949
##########
File path: learning/katas/go/Core Transforms/Map/ParDo
OneToMany/pkg/task/task.go
##########
@@ -21,10 +21,10 @@ import (
)
func ApplyTransform(s beam.Scope, input beam.PCollection) beam.PCollection {
- return beam.ParDo(s, processFn, input)
+ return beam.ParDo(s, tokenizeFn, input)
}
-func processFn(input string, emit func(out string)) {
+func tokenizeFn(input string, emit func(out string)) {
Review comment:
This looks good now
##########
File path: learning/katas/go/Core Transforms/Map/ParDo struct/pkg/task/task.go
##########
@@ -18,10 +18,7 @@ package task
import "github.com/apache/beam/sdks/go/pkg/beam"
func ApplyTransform(s beam.Scope, input beam.PCollection) beam.PCollection {
- processFn := &multiplyByFn{
- Factor: 5,
- }
- return beam.ParDo(s, processFn, input)
+ return beam.ParDo(s, &multiplyByFn{Factor: 5}, input)
Review comment:
This seems to have an issue now. There is no placeholder at all. And the
task description doesn't load properly.
Could it be because the directory name needs to be renamed to "ParDo Struct"
with capital S?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
