TheNeuralBit commented on a change in pull request #11554:
URL: https://github.com/apache/beam/pull/11554#discussion_r421075832
##########
File path: website/build.gradle
##########
@@ -91,30 +92,38 @@ task startDockerContainer(type: Exec) {
"${->createDockerContainer.containerId()}" // Lazily evaluate containerId.
}
+task initGitSubmodules(type: Exec) {
+ commandLine 'docker', 'exec', '-u', 'root',
+ "${->startDockerContainer.containerId()}", 'git',
'submodule', 'update', '--init', '--recursive'
+}
+
+task installDependencies(type: Exec) {
+ commandLine 'docker', 'exec', '-u', 'root', '--workdir',
"$dockerSourceDir",
+ "${->startDockerContainer.containerId()}", 'yarn', 'install'
+}
+
+task buildGithubSamples(type: Exec) {
+ commandLine 'docker', 'exec', '-u', 'root', '--workdir', "$dockerSourceDir",
+ "${->startDockerContainer.containerId()}", 'yarn',
'build_github_samples'
+}
Review comment:
I wonder if we should remove the `-u root` from the other docker exec
command below as well? I don't know why it's there, and I had to remove all 4
in order to be able to run `:websitePrecommit` locally.
Also once I did get it running I ran into the following error:
```
Error: Error building site: TOCSS: failed to transform "scss/main.scss"
(text/x-scss): SCSS processing failed: file
"/opt/website/www/site/assets/scss/_table-wrapper.sass", line 12, col 35:
Invalid CSS after "...the License. */": expected 1 selector or at-rule, was "*/
{}"
```
Which seems to be another issue. Need to change the comment syntax in
main.scss
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
