TheNeuralBit commented on a change in pull request #11554:
URL: https://github.com/apache/beam/pull/11554#discussion_r421113369
##########
File path: website/build.gradle
##########
@@ -91,30 +92,38 @@ task startDockerContainer(type: Exec) {
"${->createDockerContainer.containerId()}" // Lazily evaluate containerId.
}
+task initGitSubmodules(type: Exec) {
+ commandLine 'docker', 'exec', '-u', 'root',
+ "${->startDockerContainer.containerId()}", 'git',
'submodule', 'update', '--init', '--recursive'
+}
+
+task installDependencies(type: Exec) {
+ commandLine 'docker', 'exec', '-u', 'root', '--workdir',
"$dockerSourceDir",
+ "${->startDockerContainer.containerId()}", 'yarn', 'install'
+}
+
+task buildGithubSamples(type: Exec) {
+ commandLine 'docker', 'exec', '-u', 'root', '--workdir', "$dockerSourceDir",
+ "${->startDockerContainer.containerId()}", 'yarn',
'build_github_samples'
+}
Review comment:
Confirmed that removing these lines seems to have fixed the issue with
creating files owned by root. I ran
`find
/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Website_Stage_GCS_Commit/
-group root` and `find
/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Website_Commit/ -group
root` on the workers it used and they don't have any.
Also ran find with `-exec rm` on every worker to remove some root-owned
files that I seemed to have missed before. We _should_ be good now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
