TheNeuralBit commented on a change in pull request #11554: URL: https://github.com/apache/beam/pull/11554#discussion_r422324477
########## File path: website/Dockerfile ########## @@ -1,33 +1,65 @@ -############################################################################### -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at # -# http://www.apache.org/licenses/LICENSE-2.0 +# http://www.apache.org/licenses/LICENSE-2.0 # -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -############################################################################### +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. -# This image contains Ruby and dependencies required to build and test the Beam -# website. It is used by tasks in build.gradle. +FROM debian:stretch-slim -FROM ruby:2.5 +SHELL ["/bin/bash", "-o", "pipefail", "-e", "-u", "-x", "-c"] -WORKDIR /ruby -RUN gem install bundler -# Update buildDockerImage's inputs.files if you change this list. -ADD Gemfile Gemfile.lock /ruby/ -RUN bundle install --deployment --path $GEM_HOME +ENV DEBIAN_FRONTEND=noninteractive \ + LANGUAGE=C.UTF-8 \ + LANG=C.UTF-8 \ + LC_ALL=C.UTF-8 \ + LC_CTYPE=C.UTF-8 \ + LC_MESSAGES=C.UTF-8 -# Required for website testing using HTMLProofer. -ENV LC_ALL C.UTF-8 +RUN apt-get update \ + && apt-get install -y --no-install-recommends \ + ca-certificates \ + curl \ + git \ + gnupg2 \ + gosu \ + lynx \ + && apt-get autoremove -yqq --purge \ + && apt-get clean \ + && rm -rf /var/lib/apt/lists/* -CMD sleep 3600 +RUN curl -sL https://deb.nodesource.com/setup_10.x | bash - \ + && apt-get update \ + && apt-get install -y --no-install-recommends \ + nodejs \ + && apt-get autoremove -yqq --purge \ + && apt-get clean \ + && rm -rf /var/lib/apt/lists/* + +RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - \ + && echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list \ + && apt-get update \ + && apt-get install -y --no-install-recommends yarn \ + && apt-get autoremove -yqq --purge \ + && apt-get clean \ + && rm -rf /var/lib/apt/lists/* + +RUN HUGOHOME="$(mktemp -d)" \ + && export HUGOHOME \ + && curl -sL https://github.com/gohugoio/hugo/releases/download/v0.68.3/hugo_extended_0.68.3_Linux-64bit.tar.gz > "${HUGOHOME}/hugo.tar.gz" \ + && tar -xzvf "${HUGOHOME}/hugo.tar.gz" hugo \ + && mv hugo /usr/local/bin/hugo \ + && chmod +x /usr/local/bin/hugo \ + && rm -r "${HUGOHOME}" Review comment: Why not install from the debian repo with apt-get? https://gohugo.io/getting-started/installing/#debian-and-ubuntu If we keep it this way it would be nice to pull the version number out into a variable so it's easy to upgrade. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
