aaltay commented on a change in pull request #11554:
URL: https://github.com/apache/beam/pull/11554#discussion_r422427387
##########
File path: website/build.gradle
##########
@@ -236,33 +231,24 @@ def buildContentDir(name) {
}
task serveWebsite(type: Exec) {
- dependsOn setupDockerContainer, setupBuildDir
+ dependsOn setupDockerContainer
finalizedBy stopAndRemoveDockerContainer
- inputs.files 'Gemfile.lock', '_config.yml'
- inputs.dir 'src'
- outputs.dir "$buildDir/.sass-cache"
- outputs.dir buildContentDir('local')
commandLine 'docker', 'exec',
"${->setupDockerContainer.containerId()}", '/bin/bash', '-c',
- """cd $dockerWorkDir/build/website && \
- bundle exec jekyll serve \
- --config $dockerWorkDir/website/_config.yml,/tmp/_config_branch_repo.yml
\
- --incremental \
- --source $dockerWorkDir/website/src \
- --host 0.0.0.0
+ """cd $dockerSourceDir && \
+ yarn develop \
+ --bind="0.0.0.0" \
+ --config $dockerSourceDir/site/config.toml,/tmp/_config_branch_repo.toml
"""
}
task testWebsite(type: Exec) {
// dependsOn setupDockerContainer, 'buildWebsite'
finalizedBy stopAndRemoveDockerContainer
- inputs.files "$buildDir/Rakefile"
- inputs.dir buildContentDir('local')
commandLine 'docker', 'exec',
"${->setupDockerContainer.containerId()}", '/bin/bash', '-c',
- """cd $dockerWorkDir/build/website && \
- bundle exec -- rake test
disable_external=${findProperty('disableExternal') ?: true}"""
+ "$dockerSourceDir/check-links.sh $dockerBuildDir/generated-local-content"
Review comment:
Does check-links.sh cover a comparable amount of testing as the previous
rake test?
##########
File path: website/build.gradle
##########
@@ -91,30 +92,38 @@ task startDockerContainer(type: Exec) {
"${->createDockerContainer.containerId()}" // Lazily evaluate containerId.
}
+task initGitSubmodules(type: Exec) {
+ commandLine 'docker', 'exec',
+ "${->startDockerContainer.containerId()}", 'git',
'submodule', 'update', '--init', '--recursive'
+}
+
+task installDependencies(type: Exec) {
+ commandLine 'docker', 'exec', '--workdir', "$dockerSourceDir",
+ "${->startDockerContainer.containerId()}", 'yarn', 'install'
+}
+
+task buildGithubSamples(type: Exec) {
+ commandLine 'docker', 'exec', '--workdir', "$dockerSourceDir",
+ "${->startDockerContainer.containerId()}", 'yarn',
'build_github_samples'
Review comment:
What is build_github_samples ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
