pabloem commented on a change in pull request #11943:
URL: https://github.com/apache/beam/pull/11943#discussion_r439077983
##########
File path: sdks/python/apache_beam/transforms/combiners.py
##########
@@ -66,8 +66,21 @@ class Mean(object):
"""Combiners for computing arithmetic means of elements."""
class Globally(ptransform.PTransform):
"""combiners.Mean.Globally computes the arithmetic mean of the elements."""
+ def __init__(self, has_defaults=True, *args, **kwargs):
Review comment:
Can you add Pydoc for this? And I don't think we need `args` and
`kwargs` to be added. Probably take only has_defaults.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
