InigoSJ commented on a change in pull request #11943:
URL: https://github.com/apache/beam/pull/11943#discussion_r439507508
##########
File path: sdks/python/apache_beam/transforms/combiners.py
##########
@@ -66,8 +66,21 @@ class Mean(object):
"""Combiners for computing arithmetic means of elements."""
class Globally(ptransform.PTransform):
"""combiners.Mean.Globally computes the arithmetic mean of the elements."""
+ def __init__(self, has_defaults=True, *args, **kwargs):
Review comment:
I took out the `args` and `kwargs`, but didn't add the Pydoc to keep it
consistent
[`CombineGlobally`](https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/core.py#L1834)
(doesn't have it either). Let me know if you want me to add them.
Thanks again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
