mutianf commented on code in PR #17823:
URL: https://github.com/apache/beam/pull/17823#discussion_r894785971
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -844,6 +879,22 @@ public void processElement(ProcessContext c, BoundedWindow
window) throws Except
failures.add(new BigtableWriteException(c.element(),
exception));
}
});
+ if (config.getBulkMutationThrottling()) {
+ long delta = 0;
Review Comment:
you can probably get the instance outside of the lock:
ResourceLimiterStats stats = ResourcesLimiterStats.getInstance(..);
and inside the lock:
long newAgg = stats.getCumulativeThrottlingTimeNanos();
delta = ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]