mutianf commented on code in PR #17823:
URL: https://github.com/apache/beam/pull/17823#discussion_r896955222
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -241,7 +246,11 @@ public abstract static class Read extends
PTransform<PBegin, PCollection<Row>> {
static Read create() {
BigtableConfig config =
-
BigtableConfig.builder().setTableId(StaticValueProvider.of("")).setValidate(true).build();
+ BigtableConfig.builder()
+ .setTableId(StaticValueProvider.of(""))
+ .setValidate(true)
+ .setDataflowThrottleReporting(false)
Review Comment:
I think you don't need to set it here again since you're already setting it
in BigtableConfig line 80
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -563,13 +572,24 @@ public final String toString() {
return getBigtableConfig().getBigtableOptions();
}
+ /**
+ * Returns whether client's throttle time is being passed to Dataflow for
bulk mutations
+ *
+ * <p>This change is experimental and may be changed and relocated in the
future
+ */
+ @Experimental
+ public boolean isDataflowThrottleReportingEnabled() {
+ return getBigtableConfig().getDataflowThrottleReporting();
+ }
+
abstract Builder toBuilder();
static Write create() {
BigtableConfig config =
BigtableConfig.builder()
.setTableId(StaticValueProvider.of(""))
.setValidate(true)
+ .setDataflowThrottleReporting(false)
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
