ryanthompson591 commented on code in PR #21803:
URL: https://github.com/apache/beam/pull/21803#discussion_r894904365
##########
sdks/python/apache_beam/ml/inference/sklearn_inference.py:
##########
@@ -94,9 +91,6 @@ class SklearnModelHandlerPandas(ModelHandler[pandas.DataFrame,
BaseEstimator]):
""" Implementation of the ModelHandler interface for scikit-learn that
supports pandas dataframes.
-
- NOTE: This API and its implementation are under development and
- do not provide backward compatibility guarantees.
Review Comment:
OK. I can leave this note here, but I don't really see support for pandas
dataframes as something separate. Sklearn users will want it as much as numpy
array support, since sklearn models are built on top of have named inputs I'm
not really understanding why we would modify our support for numpy but not
sklearn arrays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
