robertwb commented on code in PR #21803:
URL: https://github.com/apache/beam/pull/21803#discussion_r894906204
##########
sdks/python/apache_beam/ml/inference/sklearn_inference.py:
##########
@@ -94,9 +91,6 @@ class SklearnModelHandlerPandas(ModelHandler[pandas.DataFrame,
BaseEstimator]):
""" Implementation of the ModelHandler interface for scikit-learn that
supports pandas dataframes.
-
- NOTE: This API and its implementation are under development and
- do not provide backward compatibility guarantees.
Review Comment:
It's a question of what is likely to change. I am 99% we'll want to change
the way we handle dataframes, not so sure about numpy. We could call it safe
and mark both (as long as there's still enough meat in the "non-experimental"
portions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
