tvalentyn commented on code in PR #21801: URL: https://github.com/apache/beam/pull/21801#discussion_r895921320
########## sdks/python/apache_beam/ml/inference/base.py: ########## @@ -14,6 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. # +# mypy: ignore-errors Review Comment: I think #21441 describes a different problem: supporting type inference for RunInference API users. I believe some of the approaches, that it mentions, have been implemented (adding generics), and we have some type inference capabilities (that you plan to test in another test). I'd ask, what is the remaining work there? The problem of having to disable mypy in this file seems to do with developer tooling. Do we know what causes mypy to complain? Does this problem need a separate Jira? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
