AnandInguva commented on code in PR #21801:
URL: https://github.com/apache/beam/pull/21801#discussion_r895929586


##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -14,6 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
+# mypy: ignore-errors

Review Comment:
   `pache_beam/testing/load_tests/load_test_metrics_utils.py:51: error: unused 
'type: ignore' comment
   apache_beam/ml/inference/base.py:68: error: Type variable 
"apache_beam.ml.inference.base._INPUT_TYPE" is unbound  [valid-type]
   apache_beam/ml/inference/base.py:68: note: (Hint: Use "Generic[_INPUT_TYPE]" 
or "Protocol[_INPUT_TYPE]" base class to bind "_INPUT_TYPE" inside a class)
   apache_beam/ml/inference/base.py:68: note: (Hint: Use "_INPUT_TYPE" in 
function signature to bind "_INPUT_TYPE" inside a function)
   apache_beam/ml/inference/base.py:69: error: Type variable 
"apache_beam.ml.inference.base._OUTPUT_TYPE" is unbound  [valid-type]
   apache_beam/ml/inference/base.py:69: note: (Hint: Use 
"Generic[_OUTPUT_TYPE]" or "Protocol[_OUTPUT_TYPE]" base class to bind 
"_OUTPUT_TYPE" inside a class)
   apache_beam/ml/inference/base.py:69: note: (Hint: Use "_OUTPUT_TYPE" in 
function signature to bind "_OUTPUT_TYPE" inside a function`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to