TheNeuralBit commented on code in PR #21831: URL: https://github.com/apache/beam/pull/21831#discussion_r897135935
########## sdks/python/apache_beam/dataframe/frame_base.py: ########## @@ -415,19 +415,21 @@ def wrapper(*args, **kwargs): return wrapper -def not_implemented_method(op, jira='BEAM-9547', base_type=None): +def not_implemented_method(op, issue='20318', base_type=None): """Generate a stub method for ``op`` that simply raises a NotImplementedError. For internal use only. No backwards compatibility guarantees.""" assert base_type is not None, "base_type must be specified" + issue_url = f"https://issues.apache.org/jira/{issue}."; if issue.startswith( + "BEAM-") else f"https://github.com/apache/beam/issues/{issue}"; Review Comment: This is fine for now, to be safe, but let's follow up with a change to remove the else and make sure all the BEAM- references are gone (note to self). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
