damccorm commented on code in PR #21831: URL: https://github.com/apache/beam/pull/21831#discussion_r897140299
########## sdks/python/apache_beam/dataframe/frame_base.py: ########## @@ -415,19 +415,21 @@ def wrapper(*args, **kwargs): return wrapper -def not_implemented_method(op, jira='BEAM-9547', base_type=None): +def not_implemented_method(op, issue='20318', base_type=None): """Generate a stub method for ``op`` that simply raises a NotImplementedError. For internal use only. No backwards compatibility guarantees.""" assert base_type is not None, "base_type must be specified" + issue_url = f"https://issues.apache.org/jira/{issue}."; if issue.startswith( + "BEAM-") else f"https://github.com/apache/beam/issues/{issue}"; Review Comment: That sounds good - I mostly left it because I was only guaranteed to get active issues - ones that have been closed weren't migrated and my tool neither flagged nor changed them. In theory those should have all been removed when the issue was closed, but my experience would indicate otherwise 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
