Abacn commented on PR #22023: URL: https://github.com/apache/beam/pull/22023#issuecomment-1165626219
> This approach works too, though I'd go the extra step and "invert" the test---method per error type and then testing the responses from single and batched writes via a helper method rather than special casing the error type in the loop Time_exceed and other error types are treated differently in the tested DoFn and that's why I did branching here. Fine to me since they fixes flakes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
