byronellis commented on PR #22023: URL: https://github.com/apache/beam/pull/22023#issuecomment-1165662455
It's more a comment on the structure of the test suite. In the original suite, which assumes all the results are deterministic, you want to test many different error scenarios parameterized by number of retries (number of calls parameter is redundant as its always number of retries + 1) Fixing DEADLINE_EXCEEDED changes by putting the number of retries into a range. That suggests a third maybe even cleaner approach which would be to specify a min and max number of expected calls and then just drop the sleeper check entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
