gonzojive commented on PR #21942: URL: https://github.com/apache/beam/pull/21942#issuecomment-1166217882
I added tests and revised the implementation. I noticed there is another gotcha with memfs: open readers don't see the results of writers. I addressed this in the code as well and added tests for it (that break before the commits). > Having thought about it more, a runnable example demonstrating the usage you're proposing would also be really helpful (totally up to you.) Done. Please see the updated implementation of TextIO that uses Seek to dramatically reduce the total # of read bytes. When making a change like that in TextIO, it's helpful if memfs behaves very similarly to a local file system and also implements io.Seeker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
