gonzojive commented on PR #21942: URL: https://github.com/apache/beam/pull/21942#issuecomment-1167766009
One idea is to update the interface of the memfa package to expose bytes read rather than copying a lot of the memfs implementation into the TextIO test. On Mon, Jun 27, 2022, 10:00 AM Jack McCluskey ***@***.***> wrote: > ***@***.**** approved this pull request. > > LGTM, going to loop in @lostluck <https://github.com/lostluck> for a > second set of eyes. > ------------------------------ > > In sdks/go/pkg/beam/io/filesystem/memfs/memory.go > <https://github.com/apache/beam/pull/21942#discussion_r907473286>: > > > } > > + > > +// bytesReader implements io.Reader, io.Seeker, io.Cloer for memfs "files." > > > ⬇️ Suggested change > > -// bytesReader implements io.Reader, io.Seeker, io.Cloer for memfs "files." > > +// bytesReader implements io.Reader, io.Seeker, io.Closer for memfs "files." > > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/21942#pullrequestreview-1020318674>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAUO55MD5QJ73ZOQ4LTK2DVRHM2DANCNFSM5ZFAQHDA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
