ahmedabu98 commented on code in PR #21872:
URL: https://github.com/apache/beam/pull/21872#discussion_r906871936
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1494,6 +1494,91 @@ def writer(self, test_bigquery_client=None,
buffer_size=None):
buffer_size=buffer_size)
+class WriteResult:
+ def __init__(
+ self,
+ method=None,
+ destination=None,
+ schema=None,
Review Comment:
For the scope of this PR, I agree we don't need them. Maybe down the line we
might find it useful to convey more information about the write configuration
in the return object.
I went ahead and removed those attributes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
