ahmedabu98 commented on code in PR #21872:
URL: https://github.com/apache/beam/pull/21872#discussion_r909051541
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -2531,6 +2455,126 @@ def deserialize(side_inputs):
return WriteToBigQuery(**config)
+class WriteResult:
+ """The result of a WriteToBigQuery transform.
+ """
+ def __init__(
+ self,
+ method: WriteToBigQuery.Method = None,
+ destination_load_jobid_pairs: PCollection[Tuple[
+ str, bigquery.JobReference]] = None,
+ destination_file_pairs: PCollection[Tuple[str, Tuple[str, int]]] = None,
+ destination_copy_jobid_pairs: PCollection[Tuple[
+ str, bigquery.JobReference]] = None,
+ failed_rows: PCollection[Tuple[str, dict]] = None,
+ failed_rows_with_errors: PCollection[Tuple[str, dict, list]] = None):
+
+ self._method = method
+ self._destination_load_jobid_pairs = destination_load_jobid_pairs
+ self._destination_file_pairs = destination_file_pairs
+ self._destination_copy_jobid_pairs = destination_copy_jobid_pairs
+ self._failed_rows = failed_rows
+ self._failed_rows_with_errors = failed_rows_with_errors
Review Comment:
@pabloem
Updated type annotations, can you double check?
Also, I moved the annotations to be in the parameters because I see it more
commonly like that. Let met know if that works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
