yeandy commented on code in PR #22069: URL: https://github.com/apache/beam/pull/22069#discussion_r907886973
########## sdks/python/apache_beam/examples/inference/README.md: ########## @@ -37,17 +37,18 @@ The RunInference API supports the PyTorch framework. To use PyTorch locally, fir pip install torch==1.11.0 ``` -If you are using pretrained models from Pytorch's `torchvision.models` [subpackage](https://pytorch.org/vision/0.12/models.html#models-and-pre-trained-weights), you may also need to install `torchvision`. +If you are using pretrained models from Pytorch's `torchvision.models` [subpackage](https://pytorch.org/vision/0.12/models.html#models-and-pre-trained-weights), you might also need to install `torchvision`. Review Comment: I was imagining that users could adapt these examples, which is why I worded it as "may". But for these these particular examples, they should be a "will". @rszper Should we be phrasing this with the assumption that users will use these files "as is"? If so, then we will want to say that these dependencies are a must. Maybe we could add (unless it's implied?) that if they adapt or modify the file, then the installation requirements will change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
