yeandy commented on PR #22069: URL: https://github.com/apache/beam/pull/22069#issuecomment-1171393994
I think we're still doing some final review. > I think referring to all these inputs as "named" or "called" MODEL_STATE_DICT, OUTPUT is odd. These are just placeholder we're using to refer to the arguments. Why not just refer to the arguments directly? Something like: > - `--model_state_dict_path` (**Required**): ... > - `--images_dir` (**Optional**): ... Makes sense. I was originally thinking it would be more intuitive to read this way. But I'm fine with removing all of those `OUTPUT`, `MODEL_STATE_DICT `, etc. I'll defer to your judgement on this @rszper And also, we will transfer these README changes to be reflected in doc for the RunInference webpage? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
