apilloud commented on code in PR #22002:
URL: https://github.com/apache/beam/pull/22002#discussion_r907870946
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java:
##########
@@ -274,13 +280,15 @@ private void
createRunnerAndConsumersForPTransformRecursively(
if (!pTransform.hasSpec()) {
throw new IllegalArgumentException(
String.format(
- "Cannot process transform with no spec: %s",
TextFormat.printToString(pTransform)));
+ "Cannot process transform with no spec: %s",
+ TextFormat.printer().printToString(pTransform)));
Review Comment:
Mixing cleanup changes and functional changes increases the size of the
change. Large changes are more difficult to review and more difficult to
investigate when they cause breakages. (This is a nit.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
