lukecwik commented on code in PR #22002:
URL: https://github.com/apache/beam/pull/22002#discussion_r908625158
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java:
##########
@@ -663,10 +695,47 @@ private ImmutableMap<String, ByteString>
monitoringData(BundleProcessor bundlePr
ByteString payload = monitoringInfo.getPayload();
String shortId =
shortIds.getOrCreateShortId(monitoringInfo.toBuilder().clearPayload().build());
- result.put(shortId, payload);
+ monitoringData.put(shortId, payload);
}
}
- return result.build();
+ bundleProcessor
+ .getBundleProgressReporterAndRegistrar()
+ .updateIntermediateMonitoringData(monitoringData);
Review Comment:
intermediateMonitoringData is used at ProcessBundleHandler#655 as part of
the bundle progress request
finalMonitoringData is used at ProcessBundleHandler#560 when the bundle
completes processing of user code and final metrics are gathered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
