johnjcasey commented on code in PR #21752:
URL: https://github.com/apache/beam/pull/21752#discussion_r908531791
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -1473,7 +1471,7 @@ public PCollection<KafkaRecord<K, V>> expand(PBegin
input) {
}
PCollection<KafkaSourceDescriptor> output;
if (kafkaRead.isDynamicRead()) {
- Set<String> topics = new HashSet<>();
+ List<String> topics = new ArrayList<>();
Review Comment:
In the original implementation, it was a set that got converted to a list. I
just changed it to start as a list, but it could be a set just as easily
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
