pabloem commented on code in PR #21752:
URL: https://github.com/apache/beam/pull/21752#discussion_r908746952
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -1473,7 +1471,7 @@ public PCollection<KafkaRecord<K, V>> expand(PBegin
input) {
}
PCollection<KafkaSourceDescriptor> output;
if (kafkaRead.isDynamicRead()) {
- Set<String> topics = new HashSet<>();
+ List<String> topics = new ArrayList<>();
Review Comment:
Well, I just think we'll likely have duplicates if we use a List instead of
a Set, because in line 1480 we're listing TopicPartitions and appending Topics
to the list, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
