mosche opened a new pull request, #22157:
URL: https://github.com/apache/beam/pull/22157
Summary of changes:
- Add tests to verify compatibility with Spark 3.2 and 3.3 (3.1.2 remains
the default).
- Use correct group for Dropwizard `metrics-core`. While package names
remained the same, modules have moved to a new group `io.dropwizard.metrics`.
This group is also used by Spark and leads to rather indeterministic behavior
when loading classes as outdated classes of the old group remain on the
classpath.
- Recent versions of Dropwizard `MetricRegistry` do not allow registering
arbitrary implementations of `Metric`s. Migrate to using `Gauge`.
- Spark `Sink`s have different constructors between 3.1 and later versions.
Using reflection here is fine as there's just one sink per executor.
- Change encoders/expressions for StructuredStreamingRunner to use
reflection where necessary. The overhead of this is rather low as it's just
necessary once to build the execution plan.
- Change StructuredStreamingRunner to allow using a provided / active Spark
Sessions for tests. This was critical to fix the broken tests for the metrics
integration. On shutdown Spark will stop the metrics system, after that point
it's not possible to query any metrics (from the in-memory sink) anymore.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
