mosche commented on code in PR #22157:
URL: https://github.com/apache/beam/pull/22157#discussion_r923133273
##########
runners/spark/src/main/java/org/apache/beam/runners/spark/structuredstreaming/SparkStructuredStreamingRunner.java:
##########
@@ -146,10 +146,12 @@ public SparkStructuredStreamingPipelineResult run(final
Pipeline pipeline) {
});
executorService.shutdown();
- // TODO: Streaming.
+ Runnable onTerminalState =
+ options.getUseActiveSparkSession()
+ ? () -> {}
+ : () -> translationContext.getSparkSession().stop();
Review Comment:
That transition doesn't exist anymore, the only way to get here is through
`offerNewState` which by the time of this check already replaced `state` with
`newState` (which is a terminal state and never `RUNNING`).
This was previously only used to expose `stop()` for testing purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
