lukecwik commented on a change in pull request #11919:
URL: https://github.com/apache/beam/pull/11919#discussion_r443049730
##########
File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml
##########
@@ -88,6 +88,10 @@
<suppress id="ForbidNonVendoredGuava"
files=".*zetasql.*ExpressionConverter\.java" />
<suppress id="ForbidNonVendoredGuava"
files=".*zetasql.*ZetaSQLPlannerImpl\.java" />
<suppress id="ForbidNonVendoredGuava" files=".*zetasql.*SqlAnalyzer\.java" />
+ <suppress id="ForbidNonVendoredGuava"
files=".*pubsublite.*AddUuidsTransform\.java" />
+ <suppress id="ForbidNonVendoredGuava"
files=".*pubsublite.*MessageCoderTest\.java" />
+ <suppress id="ForbidNonVendoredGuava"
files=".*pubsublite.*PubsubLiteSink\.java" />
+ <suppress id="ForbidNonVendoredGuava"
files=".*pubsublite.*UuidDeduplicationTransformTest\.java" />
Review comment:
They should not be required since they seem to be using the import as an
implementation detail within the class/method. They should instead depend on
the vendored version by importing `org.apache.beam.vendor.guava.v26_0_jre....`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
