dpcollins-google commented on a change in pull request #11919:
URL: https://github.com/apache/beam/pull/11919#discussion_r443085465
##########
File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml
##########
@@ -88,6 +88,10 @@
<suppress id="ForbidNonVendoredGuava"
files=".*zetasql.*ExpressionConverter\.java" />
<suppress id="ForbidNonVendoredGuava"
files=".*zetasql.*ZetaSQLPlannerImpl\.java" />
<suppress id="ForbidNonVendoredGuava" files=".*zetasql.*SqlAnalyzer\.java" />
+ <suppress id="ForbidNonVendoredGuava"
files=".*pubsublite.*AddUuidsTransform\.java" />
+ <suppress id="ForbidNonVendoredGuava"
files=".*pubsublite.*MessageCoderTest\.java" />
+ <suppress id="ForbidNonVendoredGuava"
files=".*pubsublite.*PubsubLiteSink\.java" />
+ <suppress id="ForbidNonVendoredGuava"
files=".*pubsublite.*UuidDeduplicationTransformTest\.java" />
Review comment:
I don't think its reasonable to avoid guava in the client library in
this situation. Doing so leaves users of the client library with a worse api
(Map<String, List<ByteString>> instead of ListMultimap<String, ByteString>) for
no gain. There is clearly already a non-vendored version of guava within beam,
and this library uses the one is used as a common dependency for all google
cloud client libraries (i.e. there should always be a version usable by it and
all other cloud client libraries). I don't think there's anything to be gained
here by removing guava in the public api.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
