mosche commented on code in PR #16947:
URL: https://github.com/apache/beam/pull/16947#discussion_r918797080
##########
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sns/SnsIO.java:
##########
@@ -281,22 +281,33 @@ public Write<T> withRetryConfiguration(RetryConfiguration
retry) {
}
/**
- * Encode the full {@code PublishResult} object, including
sdkResponseMetadata and
+ * Encode the full {@code PublishResponse} object, including
sdkResponseMetadata and
* sdkHttpMetadata with the HTTP response headers.
+ *
+ * @deprecated Writes fail fast in case of errors, no need to check
headers.
Review Comment:
This is just a clarification why there's no need for a coder that includes
HTTP response metadata, there's no change in behavior.
Plans is to remove these after a few releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
