lostluck commented on code in PR #22225: URL: https://github.com/apache/beam/pull/22225#discussion_r919084678
########## sdks/go/pkg/beam/util/diagnostics/diagnostics.go: ########## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package diagnostics + +import ( + "bufio" + "context" + "os" + + "runtime/debug" + + "github.com/apache/beam/sdks/v2/go/pkg/beam/io/filesystem" + _ "github.com/apache/beam/sdks/v2/go/pkg/beam/io/filesystem/gcs" +) + +func UploadHeapDump(ctx context.Context, dest string, additionalDataToWrite string) error { + heapDumpLoc := "heapDump" + + f, err := os.Create(heapDumpLoc) + if err != nil { + return err + } + debug.WriteHeapDump(f.Fd()) Review Comment: Doing a full debug.WriteHeapDump would definitely be expensive, but a pprof HeapProfile is an allocation sample, and is much cheaper. Technically we do take memory stats when the runner sends a WorkerStatus call, and samples can be taken very regularly without undue performance impact. But I agree we probably want to centralize some kind of "Thrashing" detection so other parts of the stack could reduce their memory usage dynamically if desired, without everything doing it's own detection. This mostly means designing with this usage in mind more than getting everything unified from the start. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
