damccorm commented on code in PR #22225: URL: https://github.com/apache/beam/pull/22225#discussion_r920353660
########## sdks/go/pkg/beam/util/diagnostics/diagnostics.go: ########## @@ -0,0 +1,131 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package diagnostics + +import ( + "bufio" + "context" + "errors" + "os" + "runtime" + "runtime/pprof" + "time" + + "github.com/apache/beam/sdks/v2/go/pkg/beam/io/filesystem" + "github.com/apache/beam/sdks/v2/go/pkg/beam/log" +) + +const ( + hProfLoc = "/tmp/hProf" + tempHProfLoc = "/tmp/hProf.tmp" +) + +// SampleForHeapProfile checks every second if it should take a heap profile, and if so +// it takes one and saves it to hProfLoc. A profile will be taken if either: +// (1) the amount of memory allocated has increased since the last heap profile was taken or +// (2) it has been 60 seconds since the last heap profile was taken +func SampleForHeapProfile(ctx context.Context) { + var maxAllocatedSoFar uint64 + maxAllocatedSoFar = 0 + samplesSkipped := 0 + for { + var m runtime.MemStats + runtime.ReadMemStats(&m) + if m.Alloc > maxAllocatedSoFar || samplesSkipped >= 60 { + samplesSkipped = 0 + maxAllocatedSoFar = m.Alloc + err := saveHeapProfile() + log.Warnf(ctx, "err - %v", err) Review Comment: Oops, good catch. ########## sdks/go/pkg/beam/util/diagnostics/diagnostics.go: ########## @@ -0,0 +1,131 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package diagnostics + +import ( + "bufio" + "context" + "errors" + "os" + "runtime" + "runtime/pprof" + "time" + + "github.com/apache/beam/sdks/v2/go/pkg/beam/io/filesystem" + "github.com/apache/beam/sdks/v2/go/pkg/beam/log" +) + +const ( + hProfLoc = "/tmp/hProf" + tempHProfLoc = "/tmp/hProf.tmp" +) + +// SampleForHeapProfile checks every second if it should take a heap profile, and if so +// it takes one and saves it to hProfLoc. A profile will be taken if either: +// (1) the amount of memory allocated has increased since the last heap profile was taken or +// (2) it has been 60 seconds since the last heap profile was taken +func SampleForHeapProfile(ctx context.Context) { + var maxAllocatedSoFar uint64 + maxAllocatedSoFar = 0 Review Comment: Oh nice, didn't realize that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
