AnandInguva commented on code in PR #22088: URL: https://github.com/apache/beam/pull/22088#discussion_r922363508
########## sdks/python/apache_beam/ml/inference/sklearn_inference_it_test.py: ########## @@ -35,10 +36,17 @@ def process_outputs(filepath): return lines [email protected] +def file_lines_sorted(filepath): + with FileSystems().open(filepath) as f: + lines = f.readlines() + lines = [l.decode('utf-8').strip('\n') for l in lines] + return sorted(lines) + + @pytest.mark.uses_sklearn @pytest.mark.it_postcommit class SklearnInference(unittest.TestCase): + @pytest.mark.skip def test_sklearn_mnist_classification(self): test_pipeline = TestPipeline(is_integration_test=False) Review Comment: ```suggestion test_pipeline = TestPipeline(is_integration_test=True) ``` ########## sdks/python/apache_beam/ml/inference/sklearn_inference_it_test.py: ########## @@ -70,6 +78,27 @@ def test_sklearn_mnist_classification(self): true_label, expected_prediction = expected_outputs[i].split(',') self.assertEqual(predictions_dict[true_label], expected_prediction) + def test_sklearn_regression(self): + test_pipeline = TestPipeline(is_integration_test=False) Review Comment: ```suggestion test_pipeline = TestPipeline(is_integration_test=True) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
