mosche commented on code in PR #22157:
URL: https://github.com/apache/beam/pull/22157#discussion_r923206039
##########
runners/spark/src/test/java/org/apache/beam/runners/spark/structuredstreaming/SparkSessionRule.java:
##########
@@ -37,23 +39,43 @@ public SparkSessionRule(String sparkMaster, Map<String,
String> sparkConfig) {
builder = SparkSession.builder();
sparkConfig.forEach(builder::config);
builder.master(sparkMaster);
+ builder.config("spark.sql.shuffle.partitions",
numDriverCores(sparkMaster));
}
public SparkSessionRule(KV<String, String>... sparkConfig) {
- this("local", sparkConfig);
+ this("local[2]", sparkConfig);
}
public SparkSessionRule(String sparkMaster, KV<String, String>...
sparkConfig) {
this(sparkMaster, Arrays.stream(sparkConfig).collect(toMap(KV::getKey,
KV::getValue)));
}
+ private static int numDriverCores(String master) {
Review Comment:
This has become obsolete with above comment, introduced a
`SparkSessionFactory`. Btw, that's the Spark terminology... see
`SparkContext.numDriverCores(String master, ...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
