egalpin commented on code in PR #22216:
URL: https://github.com/apache/beam/pull/22216#discussion_r923845424
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubMessages.java:
##########
@@ -45,7 +45,10 @@ public static com.google.pubsub.v1.PubsubMessage
toProto(PubsubMessage input) {
public static PubsubMessage fromProto(com.google.pubsub.v1.PubsubMessage
input) {
Review Comment:
Does the corresponding `toProto` method also need to be updated to support
`orderingKey`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
