egalpin commented on code in PR #22216:
URL: https://github.com/apache/beam/pull/22216#discussion_r924494933
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java:
##########
@@ -524,6 +524,16 @@ public static Read<PubsubMessage>
readMessagesWithAttributesAndMessageId() {
.build();
}
+ /**
Review Comment:
I believe to support bounded writes, on line 1329 of this file you'll need
to add explicit copying of the orderingKey as well (in the
`output.add(OutgoingMessage.of(...` section of `processElement`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
